Cleanup BaseTest.

Review Request #2963 - Created Oct. 12, 2015 and submitted

Information
John Sirois
pants
jsirois/tests/cleanup
2358, 2359, 2362
2964
79c760d...
Reviewers
pants-reviews
stuhood, tejal, zundel
Lift several utilities to more appropriate homes.
+ Both `add_products` and `add_data` were only used by `ProductsTest`;
  so move them there.
+ Fix and `populate_runtime_classpath` - it used the wrong product
  type.  Move the utility to the jvm backend tests in a new
  JvmTaskTestMixin.
+ Kill unused `workspace` @contextmanager.

 tests/python/pants_test/BUILD                             |  2 --
 tests/python/pants_test/backend/jvm/tasks/BUILD           |  1 +
 tests/python/pants_test/backend/jvm/tasks/test_jvm_run.py |  3 ++-
 tests/python/pants_test/base_test.py                      | 56 +++-----------------------------------------------
 tests/python/pants_test/goal/BUILD                        |  2 ++
 tests/python/pants_test/goal/test_products.py             | 32 ++++++++++++++++++++++++++++-
 tests/python/pants_test/jvm/BUILD                         | 13 ++++++++++--
 tests/python/pants_test/jvm/jvm_task_test_mixin.py        | 40 ++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/jvm/jvm_tool_task_test_base.py    | 25 +++++++---------------
 tests/python/pants_test/tasks/BUILD                       | 14 +++++--------
 tests/python/pants_test/tasks/task_test_base.py           |  9 +++++---
 tests/python/pants_test/tasks/test_detect_duplicates.py   | 54 +++++++++++++++++++-----------------------------
 tests/python/pants_test/tasks/test_group_task.py          |  8 +++-----
 tests/python/pants_test/tasks/test_jvm_task.py            | 20 ++++++++++--------
 tests/python/pants_test/tasks/test_jvmdoc_gen.py          | 21 +++----------------
 15 files changed, 147 insertions(+), 153 deletions(-)
This cleanup was suggested working #2358 & #2359

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/84906491

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Eric Ayers
John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Stu Hood
Ship It!
Loading...