Restructured the Export task to make the json blob reusable.

Review Request #2946 - Created Oct. 8, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/separate-export-functionality
2345
6946c0d...
Reviewers
pants-reviews
fkorotkov, jsirois, tejal, zundel
Now most of the work of Export is done by a mixin which generates
the data for the json blob, and the Export console task just prints
it.

The api of Export hasn't changed, so this should not affect
anything currently depending on export's behavior (ie the pants
intellij plugin).

The motivation for this change is to enable us to build tasks that
generate code in various formats without redoing the work done by
Export. Ideally, we should be able to replace much of the work
done in IdeGen/IdeaGen with references to the data Export creates.

This doesn't add any new functionality, so just making sure existing tests pass.

CI went green here: https://travis-ci.org/gmalmquist/pants/builds/84364987
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/84518212
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/85543184

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
Nick Howard (Twitter)
Garrett Malmquist
John Sirois
Eric Ayers
Nick Howard (Twitter)
Garrett Malmquist
Fedor Korotkov
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit e230edd381697d345ec46ea11c7374bbccedbf72, thanks John, Eric, Nick, and Fedor!

Loading...