Be more conservative about caching incremental compiles

Review Request #2940 - Created Oct. 7, 2015 and submitted

Information
Stu Hood
pants
2335
fdf8888...
Reviewers
pants-reviews
areitz, benjyw, ity, nhoward_tw, zundel

We like allowing folks to write to a local buildcache to handle cases where they miss the remote cache for some reason, but unfortunately this can allow for caching of bugs in incremental compilation, which can get pretty sticky. To bias toward correctness, this patch adds an option to control whether incremental compiles (defined as having an analysis file present) are written to the cache.

Internally, we will disable incremental compile caching on laptops, but enable it in CI where we guarantee a clean-all after every source change.

  • Add a flag to be more conservative about caching of incremental compiles
  • Skip the cache write when we've hit the cache during a double check

https://github.com/pantsbuild/pants/pull/2335

Issues

  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Eric Ayers
Benjy Weinberger
Nick Howard (Twitter)
Andy Reitz
Stu Hood
Andy Reitz
Nick Howard (Twitter)
Stu Hood
Ity Kaul
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 6f5688081d0b539b709000121ea73188d18f1658

Loading...