Fixup android local resolvers.

Review Request #2934 — Created Oct. 6, 2015 and submitted

jsirois
pants
jsirois/android/fix_resolvers
2324
2905
2938
2ebb307...
pants-reviews
gmalmquist, mateor, zundel
Previously the android local SDK resolvers used <ibiblio/> with local
file:// roots.  This led to issues resolving any <dependency/> with a
custom artifact file:// url itself.

Simplify ResolveJarsTestMixin which no longer needs a custom
ivysettings.xml as a result of this fix.

 build-support/ivy/ivysettings.xml                                             | 22 ++++++++++++++--------
 tests/python/pants_test/backend/project_info/tasks/resolve_jars_test_mixin.py | 20 +-------------------
 2 files changed, 15 insertions(+), 27 deletions(-)

This ran green locally (I have an android setup):

$ ./pants clean-all test \
  tests/python/pants_test/android/:: \
  tests/python/pants_test/backend/project_info/::

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/83968079

JS
JS
GM
  1. LGTM on green CI.

  2. 
      
JS
MA
  1. Thanks a bunch for tracking this down, John. I won't be able to run this code until I get home tonight but it LGTM.

    1. You're welcome.  Let me know how this goes for you - should work.
  2. 
      
JS
  1. Thanks guys - submitted @ https://github.com/pantsbuild/pants/commit/29c0e8180e2a53dae510f51daef6190cbb661f67
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...