Reformatting the junit output to be consistent with pants.

Review Request #2917 — Created Oct. 2, 2015 and submitted

Information
gmalmquist
pants
gmalmquist/reformat-junit-output-testcases
2301
86192b7...
Reviewers
pants-reviews
jsirois, nhoward_tw, zundel 
Now testcases are described as

  org.foo.bar.TestClass#testMethodName

Which is consistent with how tests are specified on the cli.
Manual testing.


CI went green here: https://travis-ci.org/pantsbuild/pants/builds/83206084
ZU
zundel 
  1. Ship It!
  2. nit: spurious whitespace?
  3. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   





 GM





   

   

  

 



 















 



 

  

   





 GM





   

   

  

 



 















 



 

  

   





 GM





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
In commit ee091a01fd41e46a59e67dc004c64d2a7a6acbbf





 


 










  

 
















 





 

  

   





 NH





   

   





  

 



 

  


   

   

    
 
nhoward_tw


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
    I know you've already submitted it, but I'd appreciate some unit tests for this if you have time for a follow up.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      We have another bugfix to workon in the junit runner which would be a good opportunity to add some more testing.  We are tracking this internally, but essentially we have a test suite that fails with:
      

      

      {noformat}
  Time: 196.099
                     There were 1912 failures:
                     1) Test mechanism
                     java.lang.NullPointerException
                        at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.AntJunitXmlReportListener.testStarted(AntJunitXmlReportListener.java:343)
                        at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.ForwardingListener$3.fire(ForwardingListener.java:63)
                        at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.ForwardingListener.fire(ForwardingListener.java:37)
                        at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.ForwardingListener.testStarted(ForwardingListener.java:61)
                        at __shaded_by_pants__.org.pantsbuild.tools.junit.impl.AbortableListener.testStarted(AbortableListener.java:32)
                        at org.junit.runner.notification.SynchronizedRunListener.testStarted(SynchronizedRunListener.java:49)
                        at org.junit.runner.notification.RunNotifier$3.notifyListener(RunNotifier.java:121)
                        at org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)
                        at org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:118)
                        at org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)
                        ...
{noformat}

      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 









     

    

   



  

  

   
   Loading...