Adding a summary list of failing testcases to junit_run.

Review Request #2916 - Created Oct. 1, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/summarize-junit-test-failures
2298
4a9e6b6...
Reviewers
pants-reviews
benjyw, jsirois, zundel

Previously it was kind of a pain to scroll up through
pages of output to find which tests actually failed. This
organizes that information in one place clearly at the
bottom.

This output is controlled by the --failure-summary flag.

Sample output:

                           FAILURES!!!
                           Tests run: 6,  Failures: 6

      FAILURE: java org.pantsbuild.tools.junit.ConsoleRunner ... exited non-zero (6); 3 failed targets:

          .pants.d/tmp/tmpUz0TCt/tests/org/pantsbuild/tmp/tests:one
              org.pantsbuild.tmp.tests.OneTest#testSingle

          .pants.d/tmp/tmpUz0TCt/tests/org/pantsbuild/tmp/tests:three
              org.pantsbuild.tmp.tests.subtest.ThreeTest#testTripleFirst
              org.pantsbuild.tmp.tests.subtest.ThreeTest#testTripleSecond
              org.pantsbuild.tmp.tests.subtest.ThreeTest#testTripleThird

          .pants.d/tmp/tmpUz0TCt/tests/org/pantsbuild/tmp/tests:two
              org.pantsbuild.tmp.tests.TwoTest#testTupleFirst
              org.pantsbuild.tmp.tests.TwoTest#testTupleSecond

                     Waiting for background workers to finish.
      16:08:57 00:05   [complete]
                     FAILURE

Added testcases to test_junit_tests_integration.py.

CI went green here: https://travis-ci.org/gmalmquist/pants/builds/83188162
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/83208209

Eric Ayers
Garrett Malmquist
Nick Howard (Twitter)
Garrett Malmquist
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit b282a28c6607a0f2382994f76b24f70ad8e95b63

Benjy Weinberger

   

Do we even really need this option? Why would we want to turn it off?

  1. I have no idea why someone would want to turn it off, but I figured it couldn't hurt to give the option =P

  2. It adds to the verbosity of the test output, so maybe if someone wanted things to be very brief... If everyone likes it then let's yank the option.

Loading...