Added protobuf sample

Review Request #291 — Created April 29, 2014 and submitted

zundel
pants
zundel/protobuf-example
91
pants-reviews
jsirois, travis
Added protobuf sample


JS
  1. LGTM mod licenses.
  2. Please license up throughout - see other files of the same type for the patterns:
    # Copyright 2014 Pants project contributors (see CONTRIBUTORS.md).
    # Licensed under the Apache License, Version 2.0 (see LICENSE).
  3. 
      
ZU
ZU
JS
  1. Ship It!
    1. OK - 2 ideas, since this got me error:
      $ git remote add zundel https://github.com/ericzundel/pants.git
      jsirois@gill ~/dev/3rdparty/pantsbuild-pants (master) $ git fetch zundel zundel/protobuf-example
      remote: Counting objects: 34, done.
      remote: Compressing objects: 100% (20/20), done.
      remote: Total 34 (delta 6), reused 0 (delta 0)
      Unpacking objects: 100% (34/34), done.
      From https://github.com/ericzundel/pants
       * branch            zundel/protobuf-example -> FETCH_HEAD
       * [new branch]      zundel/protobuf-example -> zundel/zundel/protobuf-example
      $ rbt patch -c 291
      Patch is being applied from request 291 with diff revision  3.
      CRITICAL:root:Object does not exist (HTTP 404, API Error 100)
      
      I successfully rbt patch -c'd this RB: https://rbcommons.com/s/twitter/r/290/
      That was done on my fork https://github.com/jsirois/pants/.
      The only potential differences:
      1.) I always push my branch to origin
      2.) I always create a pull request from it and link that PR id # as a bug in the RB bugs field.
      
      I'm guessing its one or both of these that's missing.
      I checked https://github.com/ericzundel/pants/commits/zundel/protobuf-example and although there are only 2 commits vs 3 diffs here, the contents look the same - so maybe its not 1.) but 2.) that's the issue.
  2. 
      
ZU
LA
  1. 
      
  2. Is this raw string (w/out a pants(...) wrapper) something we can use in general?
    1. Yes.  And when Patrick Lawson's big BUILD parse/Graph/Target refactor lands it will be the only way - the Pants class (aka pants) will die.
  3. 
      
JS
  1. Patched in @ https://github.com/pantsbuild/pants/commit/25afd6420ef4a9722b4ff2b56b4a32ce8cc6f210
    
    Thanks for working with us on the patch application process - we'll get the rules figured out and documented clearly.
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Loading...