Move various build graph-related files to new pkg: build_graph.

Review Request #2899 — Created Sept. 28, 2015 and submitted

benjyw
pants
948de16...
pants-reviews
jsirois, kwlzn, mateor, zundel

pants/base was getting crowded. Moving this will make it somewhat
easier to later refactor/reimplement aspects of BUILD file parsing.

Note: doesn't move some core files like target and payload, as those
are heavily referenced in plugins. A followup change *may* move
those, but with a proper deprecation cycle.

After this change there are no dependencies from base to build_graph.
Target does take a build_graph argument (but doesn't reference
the type explicitly).

Also moves cache_manager/build_invalidator to a new pants/invalidation
package, as this helped untangle weird deps.

Note to Foursquare people: This will break a couple of our internal
plugins, which will need to move their imports of VersionedTargetSet.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/82646618.

ST
  1. Works for me, but please wait for kwlzn's shipit.

  2. 
      
BE
BE
KW
  1. lgtm

  2. 
      
ZU
  1. 
      
  2. tests/python/pants_test/cache/BUILD (Diff revision 1)
     
     

    Where is this file? It seems to be new and I can't find it in the diff.

    1. It was always there, it just didn't have its own target. Instead there were two targets globbing over all the test files, so they were running multiple times... It's ~unrelated to the rest of the change, it came up while I was fixing dependencies.

  3. 
      
ZU
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

9e0d1bb6df96077d32587eb941ff9bcb16fc12d5

BE
  1. Thanks folks! Submitted as 9e0d1bb6df96077d32587eb941ff9bcb16fc12d5.

  2. 
      
MA
  1. Ship It!
  2. 
      
Loading...