Two performance hacks in build file parsing.

Review Request #2895 - Created Sept. 26, 2015 and submitted

Information
Benjy Weinberger
pants
5700449...
Reviewers
pants-reviews
jsirois, patricklaw
1. Ignore hidden dirs when scanning for BUILD files.

It can be expensive to scan inside .git, .pants.d, .local_artifact_cache
and so on, and this is never what the user means by :: anyway.

This cut the run time of ./pants list from 50 to 25 seconds at Foursquare.

2. Memoize the addressable factory instances.

This cut the run time down further, from 25 to 20 seconds.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/82244881.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Patrick Lawson
Matt Olsen
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

3a97918e305e2be2fdf39b07252b1fbfcdde389b

Benjy Weinberger

Thanks Patrick! Submitted as 3a97918e305e2be2fdf39b07252b1fbfcdde389b.

Loading...