Enable Future compatibility style checks

Review Request #2884 — Created Sept. 24, 2015 and submitted

molsen
pants
1905, 2264
5d99b46...
pants-reviews
areitz, jsirois, kwlzn, zundel

Enable Future compatibility style checks

  • Cleanup existing issues in patns
  • Enable feature in pants.ini

https://travis-ci.org/pantsbuild/pants/builds/82022048

https://travis-ci.org/pantsbuild/pants/builds/82051234

https://travis-ci.org/pantsbuild/pants/builds/82057881

https://travis-ci.org/pantsbuild/pants/builds/82064132 (still running)

JS
  1. I'm having a hard time making sense of 'stash changes for future compatibility changes' as the summary/subject/future CHANGELOG entry.
    1. I assume you are looking at the github history? I thought that the change message came from the description of the reviewboard. That commit happened because I needed to switch branches to work on something else and saved my changes.

    2. No - reading the Summary above.  Try `rbt patch -c 2884`on a fresh branch and see what it does,
  2. The six check seems too specific - IIUC there are other compat layers.  Its OK for pants code, but maybe not for people using pants on their own python code.
    1. I guess this actually makes things better for everyone using six and status quo for those not, so not a blocker, but more an observation that the check it too naive and your effort here takes it part way but not all the way home on being less naive.
    2. Fair point, I can look into a cleaner way to catch this case.

  3. 
      
JS
  1. LGTM mod the summary.
  2. How about use http://pythonhosted.org/six/#six.text_type and skip the `#noqa`'s?  I really like to avoid all no-check style comments if at all possible.
  3. 
      
MO
MO
JS
  1. 
      
  2. You could drop the PY2 guard now and the comment - even though true, the test would work fine in both.
  3. 
      
MO
JS
  1. Thanks Matt - in master @ https://github.com/pantsbuild/pants/commit/91b9a3a2cc10b48f1904795463f2739ca5ca99bd
    
    Please mark this review as submitted.
  2. 
      
MO
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/91b9a3a2cc10b48f1904795463f2739ca5ca99bd

Loading...