Fixup release dry runs; use isolated plugin cache.

Review Request #2874 - Created Sept. 23, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/2248
2248, 2256
456f563...
Reviewers
pants-reviews
benjyw, peiyu
Previously release dry runs used the global plugin cache.  This was
problematic since pants versions are static in between releases, and so
installation and use of plugins in release dry run tests would use the
last released version of a plugin instead of the version just burned to
`dist/`.  Combined with API changes across plugin boundaries since the
last release, this could lead to spurious failures.

Fix this by adding an advanced `--plugin-cache-dir` option and use this
in the release dry run pointing to a new empty temporary directory.

 build-support/bin/release.sh              | 12 +++++++++---
 src/python/pants/bin/plugin_resolver.py   |  3 ++-
 src/python/pants/option/global_options.py |  4 ++++
 3 files changed, 15 insertions(+), 4 deletions(-)

Before the fix, ./build-support/bin/release.sh failed consistently
for me, after the fix, it works.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/81849262

Benjy Weinberger
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...