Fix Go targets to glob more than '.go' files.

Review Request #2873 - Created Sept. 23, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/2249
2249, 2255
72ec489...
Reviewers
pants-reviews
kwlzn, mateor, zundel
Go packages can rely on local sibling '.c', '.cc' and other files to
build correctly and local tests might rely on loose resource files as
part of performing a test.

Allow for both of these cases by relaxing restrictions on files types
globbed by the go local source targets and by the GoWorkspaceTask when
setting up a local workspace for a remote lib.

Tests are updated to exercise these cases.

 contrib/go/src/python/pants/contrib/go/targets/go_local_source.py                  | 10 +++++++++-
 contrib/go/src/python/pants/contrib/go/tasks/BUILD                                 |  1 -
 contrib/go/src/python/pants/contrib/go/tasks/go_workspace_task.py                  |  5 +++--
 contrib/go/tests/python/pants_test/contrib/go/targets/go_local_source_test_base.py | 39 +++++++++++++++++++++++++++++++++++++++
 contrib/go/tests/python/pants_test/contrib/go/tasks/test_go_workspace_task.py      | 11 +++++++----
 5 files changed, 58 insertions(+), 8 deletions(-)

Ran green locally: ./pants clean-all test contrib/go/::

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/81831436

Kris Wilson
Mateo Rodriguez
Eric Ayers
John Sirois
John Sirois
Mateo Rodriguez
John Sirois
Vinny Fuentes
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...