Slim down the API of the Config class and move it to options/.

Review Request #2865 - Created Sept. 23, 2015 and submitted

Information
Benjy Weinberger
pants
4e758ac...
Reviewers
pants-reviews
jsirois, mateor
Remove/make private all methods that weren't used outside its test.

Move get_required into the only code that uses it. That code
(keystore_resolver.py) had to catch and re-throw all exceptions anyway,
so this didn't really add any net LoC there.

CI passes, apart from the Android release test, but I can't see why and I can't reproduce it locally, so would be grateful for any ideas.

https://travis-ci.org/pantsbuild/pants/jobs/81695546

John Sirois
John Sirois
Mateo Rodriguez
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 1c2d0930eeccd1f3939b04d64951e076683696cd.

Benjy Weinberger

Thanks guys. Submitted as 1c2d0930eeccd1f3939b04d64951e076683696cd.

Eric Ayers

   
src/python/pants/option/config.py (Diff revision 1)
 
 

It would have been great to have a deprecation on this for a cycle. Our plugin broke without warning even though our previous installation of pants is only 3 days old.

  1. Aaargh, sorry about that. Out of curiousity, why was your plugin accessing config directly? It didn't even occur to me that anything was still doing that.

  2. We have a list of config values stored there. I need to turn that into an option...

  3. Yes please... I'm not even happy that android uses config for its keystore. Would have preferred JSON.

Loading...