Use list comprehension in jvm_compile to calculate valid targets
Review Request #2843 - Created Sept. 18, 2015 and submitted
|Nick Howard (Twitter)|
|benjyw, jsirois, stuhood|
While looking at vts usages when adjusting buildcache for adding the cache hit callback, I noticed that we are doing extra work here.
Instead of doing set math with relevant_targets and invalid_targets, this creates a list from the all_vts' targets, removing the invalid ones. all_vts in this context maps onto relevant_targets, so they are equivalent but I think this is simpler and creates fewer intermediate objects / operations.
CI away at https://travis-ci.org/pantsbuild/pants/builds/81050720 . I ran some integration tests locally and had both implementations with an assert containing an equality check. I would have expected the assert to blow up if my assumptions were incorrect.
Status: Closed (submitted)