Kill 'ivy_jar_products'.

Review Request #2823 - Created Sept. 15, 2015 and submitted

Information
John Sirois
pants
jsirois/ivy_quest/ivy_jar_products/kill
1841, 2177, 2198
098eff5...
Reviewers
pants-reviews
areitz, fkorotkov, gmalmquist, nhoward_tw, patricklaw, stuhood, zundel
Previously this was only used by the IDE focused tasks: `Export` and
`IdeGen`.  Enhance ClasspathProducts by exposing ClasspathEntries and
enhance the ArtifactClasspathEntry to carry the ivy cache path of the
artifact in addition to the pants path.

Also fix up the core ivy.xml template to successfully pull extra confs
(sources and/or javadoc) when custom classifiers have been requested.
This just required using the <include/> directive for the extra confs.
Uncomment a few tests that exercise this.

 src/python/pants/backend/jvm/ivy_utils.py                                                                                     |  50 ++++++++++++-------
 src/python/pants/backend/jvm/jar_dependency_utils.py                                                                          |   9 ++--
 src/python/pants/backend/jvm/tasks/BUILD                                                                                      |   1 +
 src/python/pants/backend/jvm/tasks/classpath_products.py                                                                      |  98 ++++++++++++++++++++++++++++----------
 src/python/pants/backend/jvm/tasks/ivy_resolve.py                                                                             |  75 +++++++++++------------------
 src/python/pants/backend/jvm/tasks/ivy_task_mixin.py                                                                          |   2 +-
 src/python/pants/backend/jvm/tasks/jar_publish.py                                                                             |   2 -
 src/python/pants/backend/jvm/tasks/templates/ivy_resolve/ivy.mustache                                                         |  44 ++++++++---------
 src/python/pants/backend/project_info/tasks/BUILD                                                                             |  14 ++----
 src/python/pants/backend/project_info/tasks/export.py                                                                         |  89 +++++++++++++++++-----------------
 src/python/pants/backend/project_info/tasks/ide_gen.py                                                                        |  74 +++++++++++++++++------------
 src/python/pants/backend/project_info/tasks/projectutils.py                                                                   |  28 -----------
 tests/python/pants_test/backend/jvm/tasks/test_ivy_resolve.py                                                                 |  11 ++---
 tests/python/pants_test/backend/jvm/tasks/test_ivy_utils.py                                                                   |   2 +-
 tests/python/pants_test/backend/project_info/tasks/BUILD                                                                      |   5 +-
 tests/python/pants_test/backend/project_info/tasks/test_export.py                                                             | 129 ++++++++++++++++++--------------------------------
 tests/python/pants_test/backend/project_info/tasks/test_export_integration.py                                                 |  86 ++++++++++++++++-----------------
 tests/python/pants_test/backend/project_info/tasks/test_idea_integration.py                                                   |  39 +++++----------
 tests/python/pants_test/tasks/jar_publish_resources/org.pantsbuild.testproject.publish.hello/welcome/ivy-0.0.1-SNAPSHOT.xml   |  14 +++---
 tests/python/pants_test/tasks/jar_publish_resources/org.pantsbuild.testproject.publish/classifiers/ivy-0.0.1-SNAPSHOT.xml     |  16 +++----
 tests/python/pants_test/tasks/jar_publish_resources/org.pantsbuild.testproject.publish/hello-greet/ivy-0.0.1-SNAPSHOT.xml     |  13 +++--
 tests/python/pants_test/tasks/jar_publish_resources/org.pantsbuild.testproject.publish/jvm-example-lib/ivy-0.0.1-SNAPSHOT.xml |  14 +++---
 tests/python/pants_test/tasks/task_test_base.py                                                                               |  11 +++++
 23 files changed, 397 insertions(+), 429 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/80499611

Issues

  • 0
  • 2
  • 2
  • 4
Description From Last Updated
John Sirois
Eric Ayers
Garrett Malmquist
John Sirois
John Sirois
Nick Howard (Twitter)
Andy Reitz
John Sirois
Eric Ayers
John Sirois
Nick Howard (Twitter)
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...