Fix `NailgunExecutor` to support more than one connect attempt

Review Request #2822 - Created Sept. 14, 2015 and submitted

Information
Gabriel Gonzalez
pants
ggonzalez/fix_wait_interval
2196
195798b...
Reviewers
pants-reviews
jsirois, stuhood
In 73e25e74, the `WAIT_INTERVAL` field of `ProcessManager` was renamed to
`WAIT_INTERVAL_SEC`, except for one location in `NailgunExecutor` which broke as
a result.  This causes the `try_connect` method to fail if one connection
attempt fails, regardless of what the user supplies as the
`--nailgun-connect-attempts` flag on the command line.

I discovered this issue by using pylint and then manually verifying that the warning was correct:

$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
************* Module pants.java.nailgun_executor
E:229,17: Instance of 'NailgunExecutor' has no 'WAIT_INTERVAL' member
(no-member)

After fixing the issue the pylint warning disappears:

$ pylint -E -d no-self-argument src/python/pants/java/nailgun_executor.py
No config file found, using default configuration
Stu Hood
Gabriel Gonzalez
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as a86d0ad380557bdb30b0b7dc164757e6d81b57e6

Loading...