Kill 'ivy_resolve_symlink_map' and 'ivy_cache_dir' products.

Review Request #2819 - Created Sept. 14, 2015 and submitted

Information
John Sirois
pants
jsirois/ivy_quest/ivy_resolve_symlink_map/kill
1841, 2195
31eb9d0...
Reviewers
pants-reviews
nhoward_tw, stuhood, zundel
The 'ivy_cache_dir' product was unused within pants and anyone in need
of this info can consult the IvySubsystem.

The 'ivy_resolve_symlink_map' product was unused except internally to
the `IvyTaskMixin`/`IvyResolve` - switch to a normal return parameter
and kill the one unused task dependency on the product.  As a result,
simplify symlink handling which no longer is multi-pass as is made clear
by the product collapse.

 src/python/pants/backend/jvm/BUILD                            |  4 +--
 src/python/pants/backend/jvm/ivy_utils.py                     | 68 +++++++++++++++++++++-----------------------------
 src/python/pants/backend/jvm/tasks/BUILD                      |  8 +++---
 src/python/pants/backend/jvm/tasks/bootstrap_jvm_tools.py     |  2 +-
 src/python/pants/backend/jvm/tasks/ivy_resolve.py             | 32 +++++++++---------------
 src/python/pants/backend/jvm/tasks/ivy_task_mixin.py          | 51 +++++++++++++++++++------------------
 src/python/pants/backend/jvm/tasks/jvm_compile/BUILD          |  4 +--
 src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py |  2 --
 tests/python/pants_test/backend/jvm/tasks/test_ivy_resolve.py |  3 +--
 tests/python/pants_test/backend/jvm/tasks/test_ivy_utils.py   | 23 ++++++-----------
 10 files changed, 85 insertions(+), 112 deletions(-)

Ran ./pants test tests/python/pants_test/backend/jvm/tasks:: locally.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/80342767

John Sirois
John Sirois
Stu Hood
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...