Backport sbt java output fixes into zinc
Review Request #2810 - Created Sept. 14, 2015 and submitted
|benjyw, fkorotkov, jsirois, zundel|
This backports a fix that Fedor committed upstream to sbt, but which won't be available for consumption until sbt
ZincLocalJavaCompiler(with no changes: this is just to get access to the necessary API)
ZincDiagnosticsReporter; this is where the fix actually lives
ZincLocalJavaCompilerwhen creating compilers.
built a local zinc release and tested that the fix results in complete line output for the testcase that Eric added:./pants --config-override=pants.ini.isolated compile testprojects/src/java/org/pantsbuild/testproject/dummies:: [info] Compiling 1 Java source to /Users/stuhood/src/pants/.pants.d/compile/jvm/zinc/isolated-classes/testprojects.src.java.org.pantsbuild.testproject.dummies.compilation_failure_target... [warn] bootstrap class path not set in conjunction with -source 1.6 [warn] /Users/stuhood/src/pants/testprojects/src/java/org/pantsbuild/testproject/dummies/CompilationFailure.java:4: sun.security.x509.X500Name is internal proprietary API and may be removed in a future release [warn] import sun.security.x509.X500Name; [error] /Users/stuhood/src/pants/testprojects/src/java/org/pantsbuild/testproject/dummies/CompilationFailure.java:13: package System2 does not exist [error] System2.out.println("Hello World!"); [error] Compile failed at Sep 14, 2015 8:44:49 AM [0.111s]
Could you also add a note that this code needst to be removed in the code where we would update the version?
I was thinking here:./src/python/pants/backend/jvm/tasks/jvm_compile/scala/zinc_compile.py: return JarDependency(org='com.typesafe.sbt', name=name, rev='0.13.9', **kwargs)
Revision 2 (+206 -6)
Status: Closed (submitted)
Merged as a88a995bc2d52aa86b736620097f4820ae64370c