scrooge migration

Review Request #2808 - Created Sept. 14, 2015 and submitted

Information
Yi Cheng
pants
2217
858b0f7...
Reviewers
pants-reviews
areitz, fkorotkov, molsen, stuhood

ScroogeGen migrated into SimpleCodegenTask; synthetic_target_type property deprecated, method used instead. dummy_generator android_generator moved to contrib/scrooge/examples

Unit test modified.

Manual test SUCCESS in open source pants:

[tw-mbp-yic pants (123)]$ ./pants clean-all gen examples/src/thrift/org/pantsbuild/example/distance/:: --thrift-defaults-compiler=scrooge
[tw-mbp-yic pants (123)]$ ./pants clean-all gen examples/src/thrift/org/pantsbuild/example/precipitation/:: --thrift-defaults-compiler=scrooge
[tw-mbp-yic pants (123)]$ ./pants clean-all gen compile contrib/scrooge/examples/src/thrift/org/pantsbuild/contrib/scrooge/dummy_generator/::
[tw-mbp-yic pants (123)]$ ./pants clean-all gen compile contrib/scrooge/examples/src/thrift/org/pantsbuild/contrib/scrooge/android_generator/::

Manual test SUCCESS in pants_internal in source:

[tw-mbp-yic source ((0c271f1...))]$ ../pants_internal/pants clean-all compile science/tests/thrift/com/twitter/ads/::
[tw-mbp-yic source ((0c271f1...))]$ ../pants_internal/pants clean-all test science/tests/thrift/com/twitter/::

CI green: https://travis-ci.org/pantsbuild/pants/builds/82655087

Issues

  • 0
  • 6
  • 1
  • 7
Description From Last Updated
Yi Cheng
Yi Cheng
Yi Cheng
Yi Cheng
Yi Cheng
Yi Cheng
Yi Cheng
Matt Olsen
Yi Cheng
Yi Cheng
Matt Olsen
Stu Hood
Yi Cheng
Matt Olsen
Yi Cheng
Yi Cheng
Yi Cheng
Andy Reitz
Yi Cheng
Yi Cheng
Yi Cheng
Yi Cheng
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as eab058cfa4f3ae9ff8f33b9e4110f513d27fd3ce

Loading...