Remove ability to configure workdir locations.

Review Request #280 — Created April 25, 2014 and submitted

benjyw
pants
pants-reviews
jsirois
There's no need to be able to override the location of task workdirs,
and this allows us to get rid of a bunch of flags and pants.ini keys.

After this change we compute a unique workdir per task instance, based
on the phase/goal it's registered under, and plumb that through
the task's __init__(). That did require changing __init__'s signature
on all tasks, but it made for more straightforward code.

While at it, I also fixed a bunch of superclass __init__ invocations
to use super().

This change affects many files (every task at least has its
__init__() signature changed) but the changes are mostly tiny.

This is the first (and presumably the most invasive) step in an audit
of our flags and configs, prior to reimplementing the entire flag/config
system.
build-support/bin/ci.sh

Manually ran almost all the tasks. 
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. Yay!  I'm only hesitating on
    BUILD.antlr
    ===
    java_antlr_library(
      name='g3',
      compiler='antlr3'
      sources=globs('*.g')
    )
    
    java_antlr_library(
      name='g4',
      compiler='antlr4'
      sources=globs('*.g')
    )
  2. pants.ini (Diff revision 1)
     
     
    I think you can kill this section since you previously killed the Task (Twitter speicifc Task).
  3. src/python/pants/tasks/antlr_gen.py (Diff revision 1)
     
     
    antlr3 and antlr4 can be applied to the same set of grammars - presumably - I actually don't know if they are compatible enough for this to be possible.
  4. src/python/pants/tasks/jvmdoc_gen.py (Diff revision 1)
     
     
    I think so - yes - you could use jvmdoc.tool_name or __class__.__name__ to handle the javadoc and scaladoc subclasses.
  5. src/python/pants/tasks/provides.py (Diff revision 1)
     
     
    This does actually seem print worthy.  The output is to a file and not console, but it is - in essence - a console (leaf) task.  By default the output dir is inscrutable - down in .pants.d/. 
  6. src/python/pants/tasks/scrooge_gen.py (Diff revision 1)
     
     
    s/why/fix/ - I agree this should be normalized.
  7. src/python/pants/tasks/task.py (Diff revision 1)
     
     
    I'm fine with this, but it probably makes sense to make cheap properties @properties ans s/get_//
  8. 
      
BE
JS
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...