Centralize finding target types for an alias.

Review Request #2796 - Created Sept. 11, 2015 and submitted

Information
John Sirois
pants
jsirois/RB-2790/followup
2169
2790
b52457d...
Reviewers
pants-reviews
kwlzn, nhoward_tw
Both `ReverseDepmap` and `Filter` tasks were doing this slightly
differently, but now they share an implementation via a mixin.

Add tests for the mixin and move the test_dependees.py and
test_filter.py tests to their proper home along side it.

Also cleans up docs and whitespace along the way.

 src/python/pants/backend/core/tasks/BUILD                                   | 11 ++++++++++
 src/python/pants/backend/core/tasks/dependees.py                            |  8 +++----
 src/python/pants/backend/core/tasks/filter.py                               |  8 +++----
 src/python/pants/backend/core/tasks/target_filter_task_mixin.py             | 33 +++++++++++++++++++++++++++++
 src/python/pants/base/build_file_aliases.py                                 |  6 +++---
 tests/python/pants_test/backend/core/tasks/BUILD                            | 45 +++++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/{ => backend/core}/tasks/test_dependees.py          |  0
 tests/python/pants_test/{ => backend/core}/tasks/test_filter.py             |  0
 tests/python/pants_test/backend/core/tasks/test_target_filter_task_mixin.py | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/base/test_build_configuration.py                    |  2 ++
 tests/python/pants_test/tasks/BUILD                                         | 31 ---------------------------
 11 files changed, 157 insertions(+), 44 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/79766329
John Sirois
Nick Howard (Twitter)
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...