Fixup 'append' action handling to always respect fromfile.

Review Request #2794 - Created Sept. 10, 2015 and submitted

Information
John Sirois
pants
jsirois/options/expand_config_append_default_lists
2166
2774
1bf6deb...
Reviewers
pants-reviews
benjyw, fkorotkov, zundel
Previously, expansions weren't done for appends for either config or
flags.  Now these 2 cases are handled and the handling code is simplified
and made more obviously consistent in its handling of all value sources.
Test coverage is expanded to touch this new handling treatment.

 src/python/pants/option/parser.py              | 41 ++++++++++++++++++-----------------------
 tests/python/pants_test/option/test_options.py | 26 ++++++++++++++++++++++----
 2 files changed, 40 insertions(+), 27 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/79741112
Benjy Weinberger
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...