Plumb bytes to zincutils rebase interface

Review Request #2776 - Created Sept. 5, 2015 and submitted

Information
Patrick Lawson
pants
2140
cbce89f...
Reviewers
pants-reviews
benjyw, jsirois, stuhood, zundel

zincutils optimizes analysis parsing in a way that requires bytes-only
string replacement operations. Zinc analysis with non-ascii symbols
will fail in some circumstances when the placeholder directory strings
passed into the parser object are not strictly bytes. This change
ensures that bytes-only directory structures are passed to the rebase
method by utf-8 encoding the buildroot and setting the
AnalysisTools._PANTS_HOME_PLACEHOLDER constant to be a bytes type
rather than a "text" string.

Add a test for this particular failure and flip on name_hashing
in pants.isolated.ini. Confirmed the test fails (with a hack to
check stdout for "FAILURE", because currently we don't actually
fail on cache write failures, for good reason). The test passes
after the fix.

CI green: https://travis-ci.org/pantsbuild/pants/builds/78854681

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Patrick Lawson
Stu Hood
Eric Ayers
Eric Ayers
Eric Ayers
Stu Hood
Patrick Lawson
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks, submitted @ 49cd4d7711aa8a894d9c031d45bf40aece7d755a

Nick Howard (Twitter)
Ship It!
Loading...