Kill PANTS_VERBOSE and PANTS_BUILD_ROOT.

Review Request #2760 - Created Sept. 4, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/2118
2118, 2129
2751
7e3a20a...
Reviewers
pants-reviews
kwlzn, lahosken, nhoward_tw, zundel
The PANTS_VERBOSE env var was obsolete and just needed a logger plumbed
and the PANTS_BUILD_ROOT was unused and unuseable since code elsewhere
in Config does `os.path.join(get_buildroot(), 'pants.ini')` which
assumes no PANTS_BUILD_ROOT env var override took place (because the
default way to establish the build root is in fact the inverse of the
path join!).

Docs and messages are all updated to kill mention of these 2 dead env
vars and a few extra doc lies are removed or fixed.

 examples/src/python/example/readme.md                |  2 +-
 src/docs/first_tutorial.md                           |  2 +-
 src/docs/invoking.md                                 | 21 ++++-----------------
 src/docs/tshoot.md                                   |  2 +-
 src/python/pants/backend/python/python_chroot.py     |  9 +++++----
 src/python/pants/backend/python/tasks/python_task.py |  3 ++-
 src/python/pants/base/build_root.py                  | 21 +++++++++------------
 src/python/pants/bin/pants_exe.py                    |  4 +---
 src/python/pants/docs/howto_develop.md               |  3 ---
 tests/python/pants_test/base/test_build_root.py      |  6 +-----
 10 files changed, 25 insertions(+), 48 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/78644183
Nick Howard (Twitter)
John Sirois
John Sirois
Kris Wilson
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Eric Ayers
Ship It!
Loading...