Fixed changed goal for BUILD files in build root

Review Request #2749 - Created Sept. 2, 2015 and submitted

Information
Fedor Korotkov
pants
13d8b73...
Reviewers
pants-reviews
areitz
Fixed changed goal for BUILD files in build root

https://travis-ci.org/fkorotkov/pants/builds/78323214 in green

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Fedor Korotkov
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as c615fa154f16600c8aaefbbcce8b819a558e0cdd

Patrick Lawson

   

I think it would be better here to check if the output of relpath is '.'. Note that os.path.relpath('/foo/bar', '/foo/bar') == os.path.relpath('/foo/bar', '/foo/bar/') == '.' even though in the second example the two paths are not string-equal.

  1. addressed here https://rbcommons.com/s/twitter/r/2758/

Loading...