Refactor / bug-fix for checking jars during dep check

Review Request #2739 - Created Aug. 31, 2015 and submitted

Information
Cody Gibb
pants
2102
c2cd2fa...
Reviewers
pants-reviews
benjyw, patricklaw, stuhood
  • Factor file -> target mapping out of JvmDependencyCheck and into JvmDependencyAnalyzer (intent is to pre-emptively factor out functionality needed for dependency scoring)
  • Instead of skipping bootstrap jars during dep parsing, skip bootstrap jars during dep checking. This removes the need for a classpath indexer
  • Fix bug where 3rd party jar dependencies were being incorrectly declared as missing deps
  • parse_deps now returns only relative paths, allowing for global compile to correctly parse deps generated by different compile goals (e.g. a dep compiled by compile.java being used by compile.apt)

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/78147738

Issues

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Stu Hood
Stu Hood
Cody Gibb
Cody Gibb
Stu Hood
Cody Gibb
Cody Gibb
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 883fb3d5418096818849694b169f6b6f7c39b279

Loading...