Rid all targets of sources_rel_path parameters. [API]

Review Request #2738 - Created Aug. 31, 2015 and submitted

Information
John Sirois
pants
jsirois/source_rel_path/kill
2101
2723, 2736
2740
49f1d95...
Reviewers
pants-reviews
gmalmquist, patricklaw, stuhood, zundel
These paramaters were largely unused or else redundantly used/
misused.  The existing external users of this parameter agreed
they can adjust during the next pants upgrade cycle they have
so this change kills the parameters outright.

Fixup GoLocalSource globbing to be lazy and relative to the
spec_path so that it can employ a standard call to
`self.create_sources_field` when setting up its sources payload field.

 contrib/cpp/src/python/pants/contrib/cpp/targets/cpp_target.py        | 11 ++---------
 contrib/go/src/python/pants/contrib/go/targets/BUILD                  |  2 ++
 contrib/go/src/python/pants/contrib/go/targets/go_local_source.py     | 15 ++++++++++++---
 contrib/spindle/src/python/pants/contrib/spindle/tasks/spindle_gen.py |  8 ++------
 src/python/pants/backend/codegen/tasks/simple_codegen_task.py         |  7 ++++++-
 src/python/pants/backend/jvm/targets/jvm_target.py                    |  5 +----
 src/python/pants/backend/python/targets/python_target.py              |  5 +----
 7 files changed, 26 insertions(+), 27 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/78098070
Stu Hood
Eric Ayers
Patrick Lawson
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

John Sirois

   
Addressed here: https://rbcommons.com/s/twitter/r/2740/
Loading...