Collapse SyntheticAddress up into Address. [API]

Review Request #2730 - Created Aug. 30, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/2093
2093, 2095
2726
ec5e192...
Reviewers
pants-reviews
mateor, patricklaw, zundel
This makes Address concrete with only a single BuildFileAddress subclass
that may be removed later.  SyntheticAddress use is removed from the
pants codebase but the class is kept around for a deprecation cycle for
plugin writers with forwardings set up to Address.

 contrib/buildgen/src/python/pants/contrib/buildgen/build_file_manipulator.py             |  4 ++--
 contrib/buildgen/tests/python/pants_test/contrib/buildgen/test_build_file_manipulator.py | 26 +++++++++++++-------------
 contrib/go/src/python/pants/contrib/go/tasks/go_buildgen.py                              |  8 ++++----
 contrib/go/src/python/pants/contrib/go/tasks/go_fetch.py                                 |  4 ++--
 contrib/go/tests/python/pants_test/contrib/go/tasks/test_go_fetch.py                     |  4 ++--
 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py                    |  4 ++--
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py        |  4 ++--
 contrib/spindle/src/python/pants/contrib/spindle/tasks/spindle_gen.py                    |  6 +++---
 src/python/pants/backend/android/tasks/aapt_gen.py                                       | 14 +++++++-------
 src/python/pants/backend/android/tasks/unpack_libraries.py                               |  8 ++++----
 src/python/pants/backend/codegen/tasks/protobuf_gen.py                                   |  7 +++----
 src/python/pants/backend/codegen/tasks/simple_codegen_task.py                            |  4 ++--
 src/python/pants/backend/core/tasks/markdown_to_html.py                                  |  4 ++--
 src/python/pants/backend/jvm/targets/jar_library.py                                      |  4 ++--
 src/python/pants/backend/jvm/targets/scala_library.py                                    |  4 ++--
 src/python/pants/backend/project_info/tasks/BUILD                                        |  2 ++
 src/python/pants/backend/project_info/tasks/depmap.py                                    | 16 ----------------
 src/python/pants/backend/project_info/tasks/export.py                                    | 13 +++----------
 src/python/pants/backend/project_info/tasks/ide_gen.py                                   |  3 ++-
 src/python/pants/backend/python/targets/python_target.py                                 | 10 +++++-----
 src/python/pants/base/BUILD                                                              |  1 +
 src/python/pants/base/address.py                                                         | 40 ++++++++++++++++++++++++++--------------
 src/python/pants/base/build_file_address_mapper.py                                       |  4 ++--
 src/python/pants/base/build_graph.py                                                     |  6 +++---
 src/python/pants/base/target.py                                                          |  5 ++---
 tests/python/pants_test/backend/codegen/tasks/test_antlr_gen.py                          |  4 ++--
 tests/python/pants_test/backend/jvm/targets/test_jar_library.py                          |  8 ++++----
 tests/python/pants_test/backend/jvm/targets/test_jvm_target.py                           |  4 ++--
 tests/python/pants_test/backend/python/tasks/python_task_test_base.py                    |  8 ++++----
 tests/python/pants_test/backend/python/tasks/test_python_repl.py                         |  4 ++--
 tests/python/pants_test/base/test_address.py                                             | 27 ++++++++++++++++-----------
 tests/python/pants_test/base/test_build_configuration.py                                 |  4 ++--
 tests/python/pants_test/base/test_build_file_address_mapper.py                           |  4 ++--
 tests/python/pants_test/base/test_build_graph.py                                         | 18 +++++++++---------
 tests/python/pants_test/base/test_cmd_line_spec_parser.py                                |  6 +++---
 tests/python/pants_test/base/test_source_root.py                                         |  8 ++++----
 tests/python/pants_test/base/test_target.py                                              |  4 ++--
 tests/python/pants_test/base_test.py                                                     |  6 +++---
 tests/python/pants_test/goal/test_context.py                                             | 17 ++++++-----------
 tests/python/pants_test/targets/test_wiki_page.py                                        |  4 ++--
 40 files changed, 161 insertions(+), 170 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/77975439
Mateo Rodriguez
John Sirois
Mateo Rodriguez
Patrick Lawson
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Eric Ayers

Thanks John!

Stu Hood

   
Loading...