Populate classes_by_target using the context jar for the isolated strategy

Review Request #2720 - Created Aug. 28, 2015 and submitted

Information
Stu Hood
pants
3afd3d2...
Reviewers
pants-reviews
benjyw, fkorotkov, jsirois, kwlzn, nhoward_tw, patricklaw, zundel
  • Remove the option to not jar classpath outputs in the isolated strategy
  • Populate classes_by_target using the context jar
  • Add a simplified relpath implementation, because it was showing up inordinately hot on profiles

This avoids a filesystem walk during the population of products. That means that we do one less filesystem walk when we hit the cache, or when we're populating products for an already built target.

https://github.com/pantsbuild/pants/pull/2082


For a large classpath:
$ find .pants.d/compile/jvm -name '*.class' | wc -l
180463

Before:

21:31:49 00:14         [apt-pre]
21:31:49 00:14         [java-pre]
21:31:49 00:14         [zinc-pre]
21:31:51 00:16         [zinc-prepare]
21:31:51 00:16           [validate-zinc-analysis]
21:31:51 00:16           [isolation-zinc-pool-bootstrap]
21:31:51 00:16         [apt-prepare]
21:31:51 00:16           [validate-java-analysis]
21:31:51 00:16           [isolation-java-pool-bootstrap]
21:31:51 00:16         [zinc-execute]
21:32:17 00:42         [apt-execute]
21:32:17 00:42         [zinc-execute]
21:32:25 00:50         [zinc-finalize]
21:32:26 00:51         [apt-finalize]
21:32:26 00:51         [apt-post]
21:32:26 00:51         [java-post]
21:32:26 00:51         [zinc-post]

After:

23:26:01 00:13         [apt-pre]
23:26:01 00:13         [java-pre]
23:26:01 00:13         [zinc-pre]
23:26:02 00:14         [apt-prepare]
23:26:02 00:14           [validate-java-analysis]
23:26:02 00:14           [isolation-java-pool-bootstrap]
23:26:02 00:14         [zinc-prepare]
23:26:02 00:14           [validate-zinc-analysis]
23:26:03 00:15           [isolation-zinc-pool-bootstrap]
23:26:03 00:15         [apt-execute]
23:26:03 00:15         [zinc-execute]
23:26:16 00:28         [apt-finalize]
23:26:16 00:28         [zinc-finalize]
23:26:16 00:28         [apt-post]
23:26:16 00:28         [java-post]
23:26:16 00:28         [zinc-post]

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Stu Hood
Eric Ayers
John Sirois
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as f619b466cb6ff5407000a9eb7e162c9a75aad167

Loading...