Implementing support for Wire 2.0 multiple proto paths.

Review Request #2717 - Created Aug. 27, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/wire-multiple-proto-paths
2080
cb0c8db...
Reviewers
pants-reviews
jsirois, zundel
Wire previously expected all protos, even the ones you were only
importing (not compiling), to be under the same --proto-path
directory. This is not always (read: usually isn't) a correct
assumption.

At Square, before we were internally hacking around the lack of
multiple --proto-paths for wire by doing symlink hacks. Now that
wire supports multiple proto paths, we can support the needed
behavior (java_wire_libraries with dependencies/imports being able
to compile properly) upstream without hacks.

Updated/added tests in test_wire_gen.py.

CI went green: https://travis-ci.org/gmalmquist/pants/builds/77564122
CI went green: https://travis-ci.org/gmalmquist/pants/builds/77573901
CI went green: https://travis-ci.org/gmalmquist/pants/builds/77578250
CI went green: https://travis-ci.org/pantsbuild/pants/builds/77695702

Eric Ayers
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit f5813bc37c726bb62ece0eccaf23787ac8231592

Loading...