Normalize and decompose GoalRunner initialization and setup

Review Request #2715 - Created Aug. 27, 2015 and submitted

Information
Kris Wilson
pants
kwlzn/pantsd/goal_runner_cleanup
2078
30acbd7...
Reviewers
pants-reviews
benjyw, jsirois, nhoward_tw, stuhood, zundel

Pre-emptive cleanup of GoalRunner and friends. Thinking this will make it easier to implement (and review) some upcoming changes and generally improves readability/modability.

  • Remove {BuildFileParser,BuildGraph}.run_tracker (both currently unused AFAICT) in support of cleaner BuildGraph serialization
  • Migrate all attribute initialization to __init__()
  • Move options_bootstrapper and working_set params from setup() -> __init__() and default them
  • Decompose setup() and expand_goals_and_specs() into slightly smaller, more purposeful methods
  • Misc readability/consistency/style cleanups

https://travis-ci.org/pantsbuild/pants/builds/77429262


$ PANTS_DEV=1 ./pants clean-all compile testprojects/src/java/org/pantsbuild/testproject/javasources/::
...
               SUCCESS
Eric Ayers
Kris Wilson
John Sirois
Kris Wilson
Eric Ayers
John Sirois
Kris Wilson
John Sirois
Kris Wilson
John Sirois
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks John & Eric! submitted @ https://github.com/pantsbuild/pants/commit/fceb95f47534177cd870a5b840e93119ee57e085

Loading...