Added a maximum version to Distribution()

Review Request #270 — Created April 23, 2014 and submitted

zundel
pants
pants-reviews
jsirois
Added a maximum version to Distribution().

I encountered an incompatibility when part of the build (zinc) picked up java 1.8 in my path instead of java 1.7. This change by itself does not fix the issue, but lays some foundation to help pick a distribution less than a maximum rev.
see test_distribution.py
JS
  1. small stuff - lgtm
  2. How about lifting a nested helper function and using that for min and max?
  3. We have catch-up to do - our internal checkstyle tool is not out - but max 100 cols please.
    1. We also don't have review protocol published either, but this comment applies throughout the review in several other places.
  4. 
      
ZU
JS
  1. Looks like I missed some small stuff with indents on the 1st pass.  This should be it and then good to cherrypick.
  2. dedent 4 spaces - we use 2 space indents and I think this is 6.
  3. dedent these raise lines by 2
  4. kill trailing ', ', just 'jdk=False):'
  5. 
      
ZU
JS
  1. Ship It!
    1. Can you push this final commit to origin? I see:
      $ rbt patch -c 270
      Patch is being applied from request 270 with diff revision  3.
      CRITICAL:root:Object does not exist (HTTP 404, API Error 100)
    2. I did another push but I don't think it changed anything.
      
      $ git push -f origin
      Everything up-to-date
      
      
      
    3. Yeah - same no dice.
      
      OK - manually commited and pushed https://github.com/pantsbuild/pants/commit/595d649a612da290705abaa7c8ed77acb499f981
      Please mark this RB submitted.
      
      Thanks again.
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Loading...