Add a just-in-time check of the artifact cache to the isolated compile strategy
Review Request #2690 - Created Aug. 24, 2015 and submitted
|benjyw, fkorotkov, nhoward_tw, patricklaw, zundel|
Now that we have a single large chunk arriving in ZincCompile, the
self.invalidatedblock for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.
In the future, pushing the invalidation check down into the
workfunction that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.
- Add a double check of the cache to the isolated strategy immediately before beginning to compile.
Revision 2 (+49 -25)