Revert "Minimize the classpath pants passes to java for running tests."

Review Request #269 — Created April 23, 2014 and submitted

jsirois
pants
jsirois/cp_minimize/revert
80
pants-reviews
benjyw, tejal, travis
commit f02492d4b37c812e10bded1efc3253dfc1620545
Author: John Sirois <jsirois@twitter.com>
Date:   Wed Apr 23 11:09:30 2014 -0600

    Revert "Minimize the classpath pants passes to java for running tests."
    
    This reverts commit aa4a419785e1d45e778292ddc67df90420f60185.
    
    This change breaks code that tries to re-formulate classpaths.
    A notable example is here:
      https://github.com/twitter/util/blob/master/util-eval/src/main/scala/com/twitter/util/Eval.scala#L317
    
    We'll attack this from a different angle.

 src/python/pants/ivy/ivy.py         | 30 +++++++++++++-----------------
 src/python/pants/java/BUILD         |  1 -
 src/python/pants/java/executor.py   | 41 ++++-------------------------------------
 src/python/pants/java/util.py       | 12 ++++++------
 src/python/pants/tasks/ivy_utils.py | 30 +++++++++++++++---------------
 5 files changed, 38 insertions(+), 76 deletions(-)
None.
JS
DD
  1. Ship It!
  2. 
      
JS
TE
  1. Ship It!
  2. 
      
JS
  1. Thanks folks - submitted.
  2. 
      
JS
JS
JS
JS
Review request changed

Status: Closed (submitted)

Loading...