Created DistributionLocator subsystem with jvm-distributions option-space.

Review Request #2677 - Created Aug. 21, 2015 and submitted

Information
Garrett Malmquist
pants
gmalmquist/distribution-subsystem
2041, 2056
27b0ade...
Reviewers
pants-reviews
benjyw, jsirois, zundel

All tasks/subsystems that need to locate a jvm Distribution now
depend on the DistributionLocator.

Distribution's locate() and cached() classmethods have been
moved to DistributionLocator.

Pulled java_home, java_sysprops out of pants/goal/context.py. Those
fields were only used in three places: the JvmDependencyAnalyzer,
JmakeCompile, and ZincCompile. All three of those usages now go
through DistributionLocator directly.

Moved --jvm-jdk-paths into the DistributionLocator, becoming
--jvm-distributions-paths.

Modified lots of tests that now need instances of the subsystem.

CI passed in my own fork: https://travis-ci.org/gmalmquist/pants/builds/76639337
CI passed in my own fork: https://travis-ci.org/gmalmquist/pants/builds/76702234
CI went green: https://travis-ci.org/pantsbuild/pants/builds/77049554
CI went green: https://travis-ci.org/pantsbuild/pants/builds/77172475

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Benjy Weinberger
Eric Ayers
Garrett Malmquist
Eric Ayers
Stu Hood
Eric Ayers
John Sirois
Garrett Malmquist
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Eric Ayers
John Sirois
Garrett Malmquist
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In commit c329e91d43e458079c53fbb19a000ed50e60bbb7

Loading...