Making --coverage-open work for cobertura.

Review Request #2670 - Created Aug. 20, 2015 and submitted

Information
Justin Trobec
pants
jtrobec/coverage/fix-cobertura-open
2035
c90d391...
Reviewers
pants-reviews
benjyw, stuhood

Previously, specifying --coverage-open when the coverage processor is cobertura had no effect. This change actually causes the generated html report to be opened when that flag is present.

This is a pretty trivial change, and I'm mostly doing it on its own just to get familiar with the pants dev process before doing a larger refactoring.

Manual testing -- the following command opens the report:

./pants test.junit --coverage-processor=cobertura --coverage --coverage-force --coverage-open testprojects/tests/java/org/pantsbuild/testproject/unicode::

and this one doesn't:

./pants test.junit --coverage-processor=cobertura --coverage --coverage-force testprojects/tests/java/org/pantsbuild/testproject/unicode::

Also ran UTs via:

./pants test tests/python/pants_test:all

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Justin Trobec
Benjy Weinberger
Justin Trobec
Justin Trobec
Justin Trobec
Stu Hood
Justin Trobec
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as db661f20165e89ef22b5ab2557800c834fea493c

Loading...