Expose the ttl and install_cache properties on CachingObtainer.

Review Request #267 — Created April 23, 2014 and submitted

benjyw
commons
pants-reviews
jsirois
Expose the ttl and install_cache properties on CachingObtainer.

They're "public" anyway, in the sense that they're passed into
__init__(). But this allows the PantsObtainer subclass of CachingObtainer
 to access them in a natural way and use them to initialize the temporary
CachingObtainers it delegates to.


WI
  1. what is this for, out of curiosity?  i'd like to kill all this code, so i want to make sure that we're not depending on it in places that i have little visibility.
  2. 
      
JS
  1. This lgtm - Brian will be commenting soon.  He may need more background on the pants issue.
    1. Offline discussion implies this change is fine since the code it alters is dying and general caching application is slated for heavy re-work.
      I'll prep a cherrypick.
  2. 
      
JS
  1. In @ https://github.com/twitter/commons/commit/b3ebdadaac0cc1376c98e5b2490d42effd99a2e4
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...