Remove log options from the zinc Setup to fix performance issue

Review Request #2666 - Created Aug. 20, 2015 and submitted

Stu Hood
areitz, benjyw, fkorotkov, zundel

The Setup object is used as a cache key for compiler instances, and it turns out that missing the cache for compiler instances causes a more than 2x slowdown. In this case, as soon as the filters were non-empty, the Regex object would fail to match (doesn't implement equals.)

  • Remove log options from the Setup, since they are passed into the compile method each time anyway.

manually verified that the slowdown with filters is gone, and that filtering still works

Benjy Weinberger
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 175a3f4de2fe836647df59e4ea73058ed4764c56