Added protobuf-gen: plugins to pants.ini to allow a list of plugins to be configured

Review Request #266 — Created April 22, 2014 and submitted

zundel
pants
pants-reviews
jsirois, travis
Added protobuf-gen: plugins to pants.ini to allow a list of plugins to be configured
We have a protoc plugin in our repo that substitutes code into the generated protos. I configured it with 'plugins: ["square"]' in pants.ini and the command line option " saw --square_protobuf_out=/Users/zundel/Development/java/.pants.d/protobuf/gen-java  in the -ldebug output.  The generated .java files now have the extra code in them that the protoc plugin provides.
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Please add, default=[] and kill the pants.ini defaulting. We're actively trying to get to a world where `pip install pantsbuild.pant ... JS jsirois
ZU
ZU
JS
  1. Defaulting is the only blocker here - lgtm
  2. src/python/pants/tasks/protobuf_gen.py (Diff revision 1)
     
     
    Please add, default=[] and kill the pants.ini defaulting.  We're actively trying to get to a world where `pip install pantsbuild.pant && touch pants.ini` is all you have to do for many machines, repos.
  3. src/python/pants/tasks/protobuf_gen.py (Diff revision 1)
     
     
    Should plugins fundamentally be a map then from plugin to outdir?  I'm not sure if folks vary these in practice.  Might be worht a TODO to follow up on if you think it makes sense.
  4. 
      
ZU
JS
  1. Ship It!
    1. I'll cherry-pick this right after https://rbcommons.com/s/twitter/r/272/ goes in.
      Our travis-ci is red atm and that RB fixes.
    2. In: https://github.com/pantsbuild/pants/commit/5e6868b272957c21483d0a0a39d88f1b29d80d94
      
      Please mark this review as submitted and thanks for the patch!
    3. Heh - I totally copied in the wrong commit message - sorry about that.  The rbt patch -c fails for branches made off forks it seems.  Although perhaps you just need to make sure to push your branch to origin on the fork.  I'll chase this down better when it comes time to get https://rbcommons.com/s/twitter/r/270/ in.
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Loading...