Kill the pants() pointer.

Review Request #2650 - Created Aug. 18, 2015 and submitted

Information
Andy Reitz
pants
97916f9...
Reviewers
pants-reviews
benjyw, jsirois, molsen, stuhood, zundel

Kill the pants() pointer, per discussion in Slack: https://pantsbuild.slack.com/archives/general/p1440451305004760

Added a pants() pointer, got this exception:

[drift pants (areitz/pants_pointer_fails)]$ ./pants list ::
WARN] While parsing FilesystemBuildFile(/Users/andyr/workspace/pants/testprojects/src/scala/org/pantsbuild/testproject/publish/classifiers/BUILD):

WARN] While parsing FilesystemBuildFile(/Users/andyr/workspace/pants/testprojects/src/scala/org/pantsbuild/testproject/publish/classifiers/BUILD):


Exception caught:
  File "/Users/andyr/workspace/pants/src/python/pants/bin/pants_exe.py", line 93, in <module>
    main()
  File "/Users/andyr/workspace/pants/src/python/pants/bin/pants_exe.py", line 88, in main
    _run(exiter)
  File "/Users/andyr/workspace/pants/src/python/pants/bin/pants_exe.py", line 79, in _run
    goal_runner.setup(options_bootstrapper, working_set)
  File "/Users/andyr/workspace/pants/src/python/pants/bin/goal_runner.py", line 158, in setup
    self._expand_goals_and_specs()
  File "/Users/andyr/workspace/pants/src/python/pants/bin/goal_runner.py", line 212, in _expand_goals_and_specs
    for address in spec_parser.parse_addresses(spec, fail_fast):
  File "/Users/andyr/workspace/pants/src/python/pants/base/cmd_line_spec_parser.py", line 85, in parse_addresses
    for address in self._parse_spec(spec, fail_fast):
  File "/Users/andyr/workspace/pants/src/python/pants/base/cmd_line_spec_parser.py", line 152, in _parse_spec
    raise self.BadSpecError(error_msg)

Exception message: --------------------
Traceback (most recent call last):
  File "/Users/andyr/workspace/pants/src/python/pants/base/cmd_line_spec_parser.py", line 142, in _parse_spec
    addresses.update(self._address_mapper.addresses_in_spec_path(build_file.spec_path))
  File "/Users/andyr/workspace/pants/src/python/pants/base/build_file_address_mapper.py", line 158, in addresses_in_spec_path
    return self._address_map_from_spec_path(spec_path).keys()
  File "/Users/andyr/workspace/pants/src/python/pants/base/build_file_address_mapper.py", line 150, in _address_map_from_spec_path
    .format(message=e, spec_path=spec_path))
AddressLookupError: name 'pants' is not defined
 while executing BUILD file FilesystemBuildFile(/Users/andyr/workspace/pants/tests/python/pants_test/python/BUILD)
 Loading addresses from 'tests/python/pants_test/python' failed.

Exception message: name 'pants' is not defined
 while executing BUILD file FilesystemBuildFile(/Users/andyr/workspace/pants/tests/python/pants_test/python/BUILD)
 Loading addresses from 'tests/python/pants_test/python' failed.
Invalid BUILD files for [::]
John Sirois
Andy Reitz
Eric Ayers
Andy Reitz
Andy Reitz
John Sirois
Eric Ayers
Andy Reitz
Andy Reitz
Andy Reitz
Review request changed

Status: Closed (submitted)

Loading...