Fix goal idea issues with mistakenly identifying a test folder as regular code, missing resources folders, and resources folders overriding code folders

Review Request #2642 - Created Aug. 16, 2015 and submitted

Information
Eric Ayers
pants
zundel/idea-fix-test-folders
2001
8739e2f...
Reviewers
pants-reviews
fkorotkov, gmalmquist, tejal

Updates to goal idea to fix:
1) Including resources targets that aren't depended on by other targets
2) In source code dirs, preferring 'is_test=True'
3) In resource only dirs, preferring 'is_test=False'

This change addresses problems noted in https://rbcommons.com/s/twitter/r/2046/

CI running at https://travis-ci.org/pantsbuild/pants/builds/75979992

Added new unit tests and now the integration tests checked in previously work. Also tested in the Square repo.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Tejal Desai
Fedor Korotkov
Eric Ayers
Garrett Malmquist
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Tejal, Fedor & Garrett. Commit 34ab8524357dfca83c8402a85d64ba56824ba3c8

Loading...