add debug back to bench, complain on no jvm targets, add test

Review Request #2619 - Created Aug. 13, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1931, 1974
9722b42...
Reviewers
pants-reviews
benjyw, jsirois, stuhood

The jvm subsystem options change broke the bench task. This adds the debug option back in as a task option since it means something slightly different in the bench task.

It also causes the task to fail if there are no jvm targets reachable from the target roots.

I found it a little tricky to write a test that fully exercise the task in a unit test. I think an integration test would be a good idea for this, but I wanted to fix the regression first.

Wrote a short test, saw it fail with the missing debug option field. Added a registration for it and saw it pass. CI in https://github.com/pantsbuild/pants/pull/1974

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Stu Hood
Stu Hood
Nick Howard (Twitter)
John Sirois
Nick Howard (Twitter)
John Sirois
Nick Howard (Twitter)
John Sirois
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Nick Howard (Twitter)

Thanks everybody. Submitted at https://github.com/pantsbuild/pants/commit/af30bb8ac7985fc934a4c9b9d2d6e8b213506cee

Loading...