Improve subsystem_util.

Review Request #2603 - Created Aug. 12, 2015 and submitted

Information
John Sirois
pants
jsirois/subsystem_util/improve
1960
dc8d8cc...
Reviewers
pants-reviews
benjyw, zundel
Add a context manager that supports fully bootstrapping a Subsystem
instance.  In the process factor up the bootstrapping code for re-use by
BaseTest.

Use the subsystem_instance to address some TODOs and simplify tests.

 contrib/go/tests/python/pants_test/contrib/go/subsystems/BUILD                    |   3 +-
 contrib/go/tests/python/pants_test/contrib/go/subsystems/test_go_distribution.py  |  54 ++++++++++-----------
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/BUILD               |   1 -
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py |  11 ++---
 src/python/pants/backend/jvm/tasks/jvm_task.py                                    |   6 +--
 tests/python/pants_test/BUILD                                                     |   4 +-
 tests/python/pants_test/backend/jvm/tasks/BUILD                                   |   2 +
 tests/python/pants_test/backend/jvm/tasks/test_junit_run.py                       |  33 ++++---------
 tests/python/pants_test/backend/jvm/tasks/test_jvm_run.py                         |   2 +-
 tests/python/pants_test/backend/python/BUILD                                      |   2 -
 tests/python/pants_test/backend/python/test_python_chroot.py                      |  77 ++++++++++++++----------------
 tests/python/pants_test/base_test.py                                              |  94 +++++++++++--------------------------
 tests/python/pants_test/ivy/BUILD                                                 |  19 ++++----
 tests/python/pants_test/ivy/test_bootstrapper.py                                  |  60 ++++++++----------------
 tests/python/pants_test/ivy/test_ivy_subsystem.py                                 |  75 +++++++++++------------------
 tests/python/pants_test/option/util/fakes.py                                      | 127 +++++++++++++++++++++++++++++++++++++++-----------
 tests/python/pants_test/subsystem/subsystem_util.py                               |  34 +++++++++++++-
 17 files changed, 293 insertions(+), 311 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/75291972

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...