Fix some more missing globs in build-file-rev mode

Review Request #2591 - Created Aug. 10, 2015 and submitted

Information
David Turner
pants
841f8e0...
Reviewers
pants-reviews
nhoward_tw, stuhood, zundel

Fix some more missing globs in build-file-rev mode.

Some of these globs were caused because resources eagerly converted
the sources field to a list before its filespec had a chance to be
captured. Others were because has_sources was called on some targets,
which checks for any on-filesystem source files; in globs mode, we
only care about globs, not actual files, so we don't care if a target
has sources.

I believe this is the last of the build-file-rev related changes for now.

Manual testing.

CI green: https://travis-ci.org/pantsbuild/pants/builds/74989718

(note that the new test here is like the test in 2583, but adds one additional flavor of glob; will rebase on top of 2583 if that ships first)

Stu Hood
David Turner
Review request changed

Status: Closed (submitted)

Loading...