Handle recursive globs with build-file-rev
Review Request #2572 - Created Aug. 4, 2015 and submitted
|benjyw, jsirois, stuhood|
Previously, build-file-rev with recursive globs would fail in two ways:
1. cmd_line_spec_parser would mistakenly look for the glob directory
in the filesystem even.
- Some relative paths would contain dot components (e.g. ./foo), and
_realpath_uncached would fail to handle these.
This patch fixes both of these problems.
The recursive glob check had to move inside scan_buildfiles. To do
so, _isdir became a classmethod, so _isfile and _exists changed too,
Ran selected tests (including new tests) manually.
CI running: https://travis-ci.org/pantsbuild/pants/builds/74156071
s/recursive glob/scan/ - this gets used for your purposes to implement recursive globs, but the API also gets used in other spots - metadata Tasks - where no globs are in-sight.
@abstractmethod does nothing now - please kill and add raise NotImplementedError
You can at your option drop the surrounding  and then be iterating over a tuple.
address review comments
Revision 2 (+6 -7)
This has now happened with 2 reviews I've been reviewer on - another with Matt Olsen - but check out the 1-2 interdiff - its borked for the last 2 files: https://rbcommons.com/s/twitter/r/2572/diff/1-2/ I'm not sure how you're posting supplemental diffs, but something about it does not play well with RB.
Status: Closed (submitted)
in master at ff5410e8d9c8c71824e28ae61c42a2fa46969240