Upgrade pex to 1.0.2.

Review Request #2571 - Created Aug. 4, 2015 and submitted

Information
John Sirois
pants
jsirois/pex/upgrade
1922
7d6c0fd...
Reviewers
pants-reviews
benjyw, kwlzn, wickman
Changelog is here:
  https://pypi.python.org/pypi/pex/1.0.2

Notably, this picks up a fix for PEX-INFO trampling as outlined here:
  https://groups.google.com/d/topic/pants-devel/CuAV8AO0Hbg/discussion

 3rdparty/python/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I confirmed zip_safe now sticks using a modified pants local
python_binary target:

$ git diff -U1
diff --git a/src/python/pants/bin/BUILD b/src/python/pants/bin/BUILD
index a937b3a..4425d33 100644
--- a/src/python/pants/bin/BUILD
+++ b/src/python/pants/bin/BUILD
@@ -54,2 +54,3 @@ python_binary(
   ],
+  zip_safe=False,
 )

This both embedded and respected the embedded zip_safe flag:

$ ./pants binary src/python/pants/bin:pants_local_binary
$ unzip -qc dist/pants_local_binary.pex PEX-INFO | python -mjson.tool | grep zip_safe
    "zip_safe": false
$ PEX_VERBOSE=5 ./dist/pants_local_binary.pex --version 2>&1 | grep "zip safe"
pex: PEX is not zip safe, exploding to /home/jsirois/.pex/code/26fc5156300f74054eddaf0a5b25bed61f276dec

And pex environment variables still work to override when explicitly set:

$ PEX_FORCE_LOCAL=0 PEX_VERBOSE=5 ./dist/pants_local_binary.pex --version 2>&1 | grep "zip safe"
$

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/74151804

Kris Wilson
Brian Wickman (Twitter)
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...