Guard against NoSuchProcess in the public API.

Review Request #2551 - Created July 31, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/1897
1897, 1899
2f59cdd...
Reviewers
pants-reviews
kwlzn, patricklaw, zundel
Previously, the status, exe_name, cmdline and cmd properties could raise
when their API was to return None, this makes all apis private that can
be and then hardens cmdline (and thus cmd).

 src/python/pants/pantsd/process_manager.py             | 68 +++++++++++++++++++++++++-------------------------
 tests/python/pants_test/pantsd/test_process_manager.py | 33 +++++++++++-------------
 2 files changed, 49 insertions(+), 52 deletions(-)
This ran green locally:
```console
$ ./pants test tests/python/pants_test/pantsd/:
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/73612500

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
John Sirois
Patrick Lawson
John Sirois
Eric Ayers
Kris Wilson
Kris Wilson
John Sirois
John Sirois
Eric Ayers
Kris Wilson
John Sirois
John Sirois
Kris Wilson
John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...