Support for Go

Review Request #2544 - Created July 30, 2015 and submitted

Information
Cody Gibb
pants
1885
e29f41d...
Reviewers
pants-reviews
benjyw, dturner-tw, gmalmquist, jsirois, mateor, stuhood

Implements basic fetching, compiling, running, and testing Go code in Pants.

This RB is intended as a sanity check for the design / implementation of Go tasks and targets. If everything so far looks to be reasonable, then I will follow up with two more reviews:
1. Transitive dependency resolution for remote packages
2. Integration / unit testing

Also, please keep in mind that some design decisions in my implementation differ from the design draft I sent out last week.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/75123556

Issues

  • 1
  • 15
  • 1
  • 17
Description From Last Updated
Not sure what the check for this is, but I worry that a failure during _download_zip will cause a half-finished ... David Turner David Turner
John Sirois
David Turner
Cody Gibb
David Turner
Stu Hood
Mateo Rodriguez
Cody Gibb
Cody Gibb
Stu Hood
John Sirois
Cody Gibb
John Sirois
Cody Gibb
Stu Hood
Cody Gibb
John Sirois
Cody Gibb
Cody Gibb
Cody Gibb
Cody Gibb
Cody Gibb
John Sirois
Cody Gibb
John Sirois
Cody Gibb
John Sirois
Cody Gibb
John Sirois
Cody Gibb
John Sirois
John Sirois
Cody Gibb
Review request changed

Status: Closed (submitted)

Jonathan Simms

   
contrib/go/examples/src/go/hello/main.go (Diff revision 13)
 
 
 
 
 
 
 
 

Just as a suggestion, the .go files should have gofmt run on them so that they're in canonical format. This looks like 2-space indents.

Loading...