Move thrift utils only used by scrooge to contrib/scrooge.

Review Request #2535 — Created July 27, 2015 and submitted

jsirois
pants
jsirois/thrift/cleanup
1876
dacff84...
pants-reviews
stuhood, tejal
Since the top-level utility functions are moved out of thrift_util,
this change takes the opportunity to also rename thrift_util.py and
likewise its dependency, binary_util.py.  The rest is import and BUILD
dep fallout.

 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/BUILD                                                   | 31 ++++++++++++++++-----------
 contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py                                          | 44 +++++++++-----------------------------
 {src/python/pants => contrib/scrooge/src/python/pants/contrib/scrooge/tasks}/thrift_util.py                    | 55 +----------------------------------------------
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/BUILD                                            | 44 ++++++++++++++++++++++++--------------
 contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py                              | 48 ++++++++++++++++++++---------------------
 {tests/python/pants_test => contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks}/test_thrift_util.py | 15 +++++++------
 src/python/pants/BUILD                                                                                         | 25 ----------------------
 src/python/pants/backend/codegen/tasks/BUILD                                                                   |  6 +++---
 src/python/pants/backend/codegen/tasks/apache_thrift_gen.py                                                    |  2 +-
 src/python/pants/backend/codegen/tasks/protobuf_gen.py                                                         |  2 +-
 src/python/pants/backend/codegen/tasks/ragel_gen.py                                                            |  2 +-
 src/python/pants/backend/core/tasks/BUILD                                                                      |  9 ++++----
 src/python/pants/backend/core/tasks/confluence_publish.py                                                      |  2 +-
 src/python/pants/backend/core/tasks/markdown_to_html.py                                                        |  2 +-
 src/python/pants/backend/core/tasks/reporting_server.py                                                        |  5 +----
 src/python/pants/backend/jvm/tasks/BUILD                                                                       | 16 +++++++-------
 src/python/pants/backend/jvm/tasks/ivy_resolve.py                                                              |  2 +-
 src/python/pants/backend/jvm/tasks/jar_task.py                                                                 |  2 +-
 src/python/pants/backend/jvm/tasks/junit_run.py                                                                |  2 +-
 src/python/pants/backend/jvm/tasks/jvmdoc_gen.py                                                               |  2 +-
 src/python/pants/backend/project_info/tasks/BUILD                                                              |  4 ++--
 src/python/pants/backend/project_info/tasks/ide_gen.py                                                         |  2 +-
 src/python/pants/backend/python/BUILD                                                                          |  2 +-
 src/python/pants/backend/python/tasks/BUILD                                                                    | 10 ++++-----
 src/python/pants/backend/python/tasks/python_task.py                                                           |  2 +-
 src/python/pants/binaries/BUILD                                                                                | 26 ++++++++++++++++++++++
 src/python/pants/binaries/__init__.py                                                                          |  0
 src/python/pants/{ => binaries}/binary_util.py                                                                 |  2 +-
 src/python/pants/binaries/thrift_binary.py                                                                     | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/BUILD                                                                                  | 22 -------------------
 tests/python/pants_test/backend/python/BUILD                                                                   | 14 ++++++------
 tests/python/pants_test/backend/python/test_python_chroot.py                                                   |  4 ++--
 tests/python/pants_test/binaries/BUILD                                                                         | 18 ++++++++++++++++
 tests/python/pants_test/binaries/__init__.py                                                                   |  0
 tests/python/pants_test/{ => binaries}/test_binary_util.py                                                     |  4 ++--
 35 files changed, 239 insertions(+), 245 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/72874687
JS
  1. This is part of the work to address fingerprinting the ThriftBinary subsystem dependency of ApacheThriftGen that fell out of review feedback on https://rbcommons.com/s/twitter/r/2511/
  2. 
      
JS
IT
  1. lgtm for the move

  2. 
      
JS
  1. Thanks Ity - submitted @ https://github.com/pantsbuild/pants/commit/3a87adf9089ef2e84815840c6a78165a378efd49
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...