Migrate ApacheThriftGen to SimpleCodegenTask.

Review Request #2534 - Created July 26, 2015 and submitted

Information
John Sirois
pants
jsirois/issues/1863
1863, 1873
63f9b1f...
Reviewers
pants-reviews
areitz, gmalmquist, mateor

The existing example
examples/src/java/org/pantsbuild/example/make_it_rain still publishes
correctly with an appropriate sources jar for precipitation-thrift-java. This
example exercises the -I case but a proper set of unit and integration tests
is in order.

contrib/scrooge/tests/thrift/org/pantsbuild/contrib/scrooge/thrift_linter/BUILD | 6 +-
contrib/scrooge/tests/thrift/org/pantsbuild/contrib/scrooge/thrift_linter/{bad.thrift => bad-default.thrift} | 2 +-
contrib/scrooge/tests/thrift/org/pantsbuild/contrib/scrooge/thrift_linter/{bad.thrift => bad-non-strict.thrift} | 2 +-
contrib/scrooge/tests/thrift/org/pantsbuild/contrib/scrooge/thrift_linter/{bad.thrift => bad-strict.thrift} | 2 +-
examples/src/java/org/pantsbuild/example/make_it_rain/BUILD | 19 ++-
migrations/options/src/python/migrate_config.py | 18 +++
pants.ini | 18 +--
src/python/pants/backend/codegen/tasks/BUILD | 11 +-
src/python/pants/backend/codegen/tasks/apache_thrift_gen.py | 319 +++++++++++++-------------------------------------
src/python/pants/thrift_util.py | 14 ---
tests/python/pants_test/backend/project_info/tasks/test_export_integration.py | 32 +++--
11 files changed, 143 insertions(+), 300 deletions(-)

Ran the examples/src/java/org/pantsbuild/example/make_it_rain example
and verified the precipitation-thrift-java sources jar had a proper
directory structure (no leading gen-java/ dir, just org/...).

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/72838660

Stu Hood
Mateo Rodriguez
John Sirois
Garrett Malmquist
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...